Skip to content

Add conditional auth config for max http connections#8170

Open
Miranlfk wants to merge 2 commits into
wso2:masterfrom
Miranlfk:master
Open

Add conditional auth config for max http connections#8170
Miranlfk wants to merge 2 commits into
wso2:masterfrom
Miranlfk:master

Conversation

@Miranlfk

@Miranlfk Miranlfk commented Jun 19, 2026

Copy link
Copy Markdown
Member

Purpose

This pull request introduces new configuration options for managing HTTP connection limits specifically for conditional authentication scenarios. The changes add parameters for maximum total connections and maximum connections per route, ensuring better control and scalability for conditional authentication flows.

New configuration options for conditional authentication HTTP connections:

  • Added ConditionalAuthMaxTotalConnections and ConditionalAuthMaxTotalConnectionsPerRoute parameters to the identity.xml file to define connection limits for conditional authentication.
  • Updated the identity.xml.j2 template to support templated values for these new parameters, allowing customization via deployment configuration.
  • Introduced corresponding default values for these parameters in org.wso2.carbon.identity.core.server.feature.default.json.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 36366529-26f9-400c-82fe-742b922b35af

📥 Commits

Reviewing files that changed from the base of the PR and between 63adba1 and 005b442.

📒 Files selected for processing (3)
  • features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/identity.xml
  • features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/identity.xml.j2
  • features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/org.wso2.carbon.identity.core.server.feature.default.json
📝 Walkthrough

Walkthrough

Two new <AdaptiveAuth> configuration elements, ConditionalAuthMaxTotalConnections and ConditionalAuthMaxTotalConnectionsPerRoute, are added with a default value of 20 across the static identity.xml, its Jinja2 template counterpart, and the feature's default JSON configuration file.

Changes

Conditional Auth HTTP connection limit configuration

Layer / File(s) Summary
ConditionalAuth connection limit config across all three artifacts
features/identity-core/.../resources/org.wso2.carbon.identity.core.server.feature.default.json, features/identity-core/.../resources/identity.xml.j2, features/identity-core/.../resources/identity.xml		 Registers authentication.adaptive.conditional_auth_http_connections.max and .max_per_route (both "20") in the default JSON, wires them into identity.xml.j2 as <ConditionalAuthMaxTotalConnections> and <ConditionalAuthMaxTotalConnectionsPerRoute>, and sets those same elements to 20 in the static identity.xml.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers Purpose, documents the specific configuration changes made across three files, but lacks several required template sections like Goals, Approach, User stories, Release note, Documentation, and testing details. Add missing sections from the template: Goals (solution details), Approach (implementation method), User stories, Release note, Documentation links, and Automation tests information to meet repository requirements.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding conditional auth configuration for max HTTP connections, which is the primary objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Jun 19, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.93%. Comparing base (08c020f) to head (005b442).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #8170   +/-   ##
=========================================
  Coverage     52.93%   52.93%           
- Complexity    20979    20987    +8     
=========================================
  Files          2197     2197           
  Lines        129215   129206    -9     
  Branches      19239    19237    -2     
=========================================
- Hits          68400    68398    -2     
+ Misses        52479    52469   -10     
- Partials       8336     8339    +3
Flag Coverage Δ
unit 38.20% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Miranlfk